From b1c6d99e4a9279c8679438cfcacb8fb78b9ddb5a Mon Sep 17 00:00:00 2001 From: unanmed <1319491857@qq.com> Date: Tue, 15 Sep 2026 10:47:23 +0800 Subject: [PATCH] docs(06-12): complete replay + enemy-model coverage gap-fill plan --- .planning/ROADMAP.md | 4 +- .planning/STATE.md | 21 ++- .planning/WINDOWS.md | 32 +++- .../phases/06-unit-tests/06-12-SUMMARY.md | 164 ++++++++++++++++++ .../phases/06-unit-tests/06-TEST-FINDINGS.md | 21 +++ .planning/state.json | 2 +- 6 files changed, 229 insertions(+), 15 deletions(-) create mode 100644 .planning/phases/06-unit-tests/06-12-SUMMARY.md diff --git a/.planning/ROADMAP.md b/.planning/ROADMAP.md index 19a7271..84640cd 100644 --- a/.planning/ROADMAP.md +++ b/.planning/ROADMAP.md @@ -243,7 +243,7 @@ Plans: - [x] 06-10-PLAN.md — combat/enemy combination gaps: G-06-01-A/B/C + G-06-07-A - [x] 06-11-PLAN.md — hero/map gaps: G-06-05-A + G-06-06-A/B/C -- [ ] 06-12-PLAN.md — replay/enemy gaps: G-06-04-B (runnable) + G-06-04-A/G-06-03-A (correct-expectation skip) +- [x] 06-12-PLAN.md — replay/enemy gaps: G-06-04-B (runnable) + G-06-04-A/G-06-03-A (correct-expectation skip) - [ ] 06-13-PLAN.md — save/load gaps: G-06-09-A/B (only plan testing saveState/loadState, D-32) ## Progress @@ -258,4 +258,4 @@ Phases execute in numeric order: 1 → 2 → 3 → 4 → 5 → 6 | 3. 数据端完成 | 19/19 | Complete | 2026-09-12 | | 4. 渲染适配与双布局 | 0/TBD | Not started | - | | 5. Legacy 移植 | 0/TBD | Not started | - | -| 6. 单元测试 | 11/13 | In Progress| | +| 6. 单元测试 | 12/13 | In Progress| | diff --git a/.planning/STATE.md b/.planning/STATE.md index 504cec0..893215a 100644 --- a/.planning/STATE.md +++ b/.planning/STATE.md @@ -4,16 +4,16 @@ milestone: v1.0 current_phase: 06 current_phase_name: unit-tests status: executing -stopped_at: Completed 06-11-PLAN.md (hero + map gap-fill) -last_updated: "2026-09-15T02:30:10.403Z" +stopped_at: Completed 06-12-PLAN.md (replay + enemy-model gap-fill) +last_updated: "2026-09-15T02:45:50.273Z" last_activity: 2026-09-15 last_activity_desc: Phase 06 execution started -state_head: 309f1b185024a6744c92706aef407d90dabe6106 +state_head: e2c163899d24c0e327af9631215802cc468feb51 progress: total_phases: 6 completed_phases: 0 total_plans: 50 - completed_plans: 48 + completed_plans: 49 milestone_name: milestone --- @@ -29,9 +29,9 @@ See: .planning/PROJECT.md (updated 2026-09-10) ## Current Position Phase: 06 (unit-tests) — EXECUTING -Plan: 11 of 13 (06-11 gap-fill complete; 06-12..06-13 pending) -Status: Phase 06 gap-fill batch (D-46) in progress — 06-11 (G-06-05-A, G-06-06-A/B/C) complete; pnpm test:ci green (66 files / 641 passed / 20 skipped) -Last activity: 2026-09-15 — Completed 06-11-PLAN.md +Plan: 12 of 13 (06-12 gap-fill complete; 06-13 pending) +Status: Phase 06 gap-fill batch (D-46) in progress — 06-12 (G-06-04-A/B, G-06-03-A) complete; pnpm test:ci green (66 files / 644 passed / 22 skipped) +Last activity: 2026-09-15 — Completed 06-12-PLAN.md Progress: [█████░░░░░] 50% @@ -89,6 +89,7 @@ Progress: [█████░░░░░] 50% | Phase 06 P07 | 40min | 4 tasks | 4 files | | Phase 06 P10 | 15min | 3 tasks | 4 files | | Phase 06 P11 | 10min | 3 tasks | 5 files | +| Phase 06 P12 | 13min | 3 tasks | 3 files | ## Accumulated Context @@ -186,6 +187,8 @@ Recent decisions affecting current work: - [Phase 06]: 06-11：G-06-06-A 的 keepEvent=false 按写回块 num 重推默认事件（[[10,'base-event']]，非目标格原块 2 的 [[20,'alternate-event']]），两分支仅以 30:'moved-event' 是否保留区分 - [Phase 06]: 06-11：G-06-06-A 共同前置须在 transferToDynamic 前 layer.getTile(0,0) 物化源格静态图块，否则归零后惰性构造的 StaticTile 读不到默认事件 - [Phase 06]: 06-11：G-06-06-C 的 compareWith 参考数组必须等于各图层当前内容（含非零格），全零参考会把 low/mid 判脏；缺口补测按 D-43 三阶段执行，无新增码、无疑似 bug、无 it.skip +- [Phase 06]: 06-12：G-06-04-B 异质多命令序列读回只比较 command/params（读流 index = position + 1、get index = i），不整体 toEqual +- [Phase 06]: 06-12：G-06-04-A/G-06-03-A 复用既有 #06-04-1/#06-04-2/#06-03-1 锚点，按 D-05 写正确预期 it.skip，不新建 #06-12-N 条目（无新疑似 bug） ### Pending Todos @@ -215,6 +218,6 @@ None yet. ## Session Continuity -Last session: 2026-09-15T02:29:56.059Z -Stopped at: Completed 06-11-PLAN.md (hero + map gap-fill) +Last session: 2026-09-15T02:45:50.033Z +Stopped at: Completed 06-12-PLAN.md (replay + enemy-model gap-fill) Resume file: None diff --git a/.planning/WINDOWS.md b/.planning/WINDOWS.md index 4b75cd6..32b172c 100644 --- a/.planning/WINDOWS.md +++ b/.planning/WINDOWS.md @@ -1,10 +1,10 @@ --- schema_version: 1 -open_count: 14 +open_count: 16 waived_count: 0 fixed_count: 8 -total_count: 22 -last_updated: 2026-09-14T09:03:38.649Z +total_count: 24 +last_updated: 2026-09-15T02:46:32.772Z --- # Broken Windows Ledger @@ -37,6 +37,8 @@ last_updated: 2026-09-14T09:03:38.649Z | 20 | 06 | skipped-test | packages-user/data-system/src/combat/mapDamage.test.ts | | 06-01-2 suspected bug: MapDamage.deleteEnemy leaves enemy-sourced damage (Finding #06-01-2) | open | | 2026-09-14T00:54:03.338Z | | | 21 | 06 | skipped-test | packages-user/data-system/src/combat/combat.test.ts | | 06-01-3 suspected bug: CombatFlow.before truthy/falsy semantics inverted vs interface doc (Finding #06-01-3) | open | | 2026-09-14T00:54:04.044Z | | | 22 | 06 | skipped-test | packages-user/data-common/src/common/mover.test.ts | | backward(count>1) 方向摆动、净位移为零（#06-08-1），已 it.skip 待用户确认 | open | | 2026-09-14T09:03:38.649Z | | +| 23 | 06 | skipped-test | packages-user/data-common/src/replay/array.test.ts | | 受阻塞缺口 G-06-04-A：多字节 bigint / 超 int32 int64 编解码缺陷 #06-04-1/#06-04-2 未修复，正确预期用例保持 it.skip | open | | 2026-09-15T02:46:32.026Z | | +| 24 | 06 | skipped-test | packages-user/data-base/src/enemy/manager.test.ts | | 受阻塞缺口 G-06-03-A：复用映射未接入 createEnemy/createEnemyById（#06-03-1），四朝向复用生成独立怪物的正确预期用例保持 it.skip | open | | 2026-09-15T02:46:32.772Z | | ````json [ @@ -303,6 +305,30 @@ last_updated: 2026-09-14T09:03:38.649Z "reason": "", "recorded_at": "2026-09-14T09:03:38.649Z", "resolved_at": null + }, + { + "id": 23, + "kind": "skipped-test", + "phase": "06", + "file": "packages-user/data-common/src/replay/array.test.ts", + "line": null, + "description": "受阻塞缺口 G-06-04-A：多字节 bigint / 超 int32 int64 编解码缺陷 #06-04-1/#06-04-2 未修复，正确预期用例保持 it.skip", + "status": "open", + "reason": "", + "recorded_at": "2026-09-15T02:46:32.026Z", + "resolved_at": null + }, + { + "id": 24, + "kind": "skipped-test", + "phase": "06", + "file": "packages-user/data-base/src/enemy/manager.test.ts", + "line": null, + "description": "受阻塞缺口 G-06-03-A：复用映射未接入 createEnemy/createEnemyById（#06-03-1），四朝向复用生成独立怪物的正确预期用例保持 it.skip", + "status": "open", + "reason": "", + "recorded_at": "2026-09-15T02:46:32.772Z", + "resolved_at": null } ] ```` diff --git a/.planning/phases/06-unit-tests/06-12-SUMMARY.md b/.planning/phases/06-unit-tests/06-12-SUMMARY.md new file mode 100644 index 0000000..97790bc --- /dev/null +++ b/.planning/phases/06-unit-tests/06-12-SUMMARY.md @@ -0,0 +1,164 @@ +--- +phase: 06-unit-tests +plan: 12 +subsystem: testing +tags: [vitest, replay, replay-array, enemy-manager, coverage-gap, it-skip] + +# Dependency graph +requires: + - phase: 06-unit-tests + provides: 06-03 enemy 数据模型单测（EnemyManager reuse mapping）与 06-04 录像系统单测（ReplayArray 编解码/读流） +provides: + - G-06-04-B 可跑绿：6 条异质录像命令（参数个数与类型各异）经 createReadStream 与 get 逐条读回一致，含 uint16 加宽与删除首步 + - G-06-04-A 受阻塞的正确预期 it.skip：多字节 bigint + 超 int32 int64 混合步骤（锚定 #06-04-1/#06-04-2） + - G-06-03-A 受阻塞的正确预期 it.skip：4 朝向 code/id 复用同一 prefab 生成 4 个独立怪物（锚定 #06-03-1） + - 06-COVERAGE-MAP.md 06-12 小节（缺口 → 用例 → 文件 → 计划 映射） +affects: [06-verify-work, 06-unit-tests 缺口收口] + +# Actuals (#2632) — pairs with the plan's `estimate` to calibrate future estimates. +actuals: + tokens: 2240 + tasks: 3 + commits: 3 + +tech-stack: + added: [] + patterns: + - "受阻塞缺口：按正确预期编写 + it.skip + 中文注释锚定 06-TEST-FINDINGS.md 既有条目，保持 pnpm test:ci 全绿（D-05/D-46）" + - "读流与按索引读回的索引语义差异（index = position + 1 vs index = i）用 toMatchObject 只比较 command/params" + +key-files: + created: [] + modified: + - packages-user/data-common/src/replay/array.test.ts + - packages-user/data-base/src/enemy/manager.test.ts + - .planning/phases/06-unit-tests/06-COVERAGE-MAP.md + +key-decisions: + - "G-06-04-B 只比较 command/params（不整体 toEqual），规避读流 index = position + 1 与 get index = i 的 ±1 差异" + - "G-06-04-A / G-06-03-A 复用既有 #06-04-1/#06-04-2/#06-03-1 锚点，不新建 #06-12-N 条目（无新疑似 bug）" + - "删除首步（delete(0)）为当前可用路径（#06-04-3 仅阻塞中间删除），据此覆盖异质序列删除后的读回" + +patterns-established: + - "异质序列读回：内联 heterogeneousSteps 期望表 + 文件内 expectHeterogeneousRead 复用同一份期望" + +requirements-completed: [TEST-01] + +coverage: + - id: D1 + description: "G-06-04-B：异质多命令序列读回（6 条命令、参数个数与类型各异，含 uint16 加宽与删除首步）可跑绿" + requirement: "TEST-01" + verification: + - kind: unit + ref: "packages-user/data-common/src/replay/array.test.ts#reads back a heterogeneous command sequence through both the stream and get" + status: pass + - kind: unit + ref: "packages-user/data-common/src/replay/array.test.ts#reads back the heterogeneous sequence after widening to uint16" + status: pass + - kind: unit + ref: "packages-user/data-common/src/replay/array.test.ts#reads back a heterogeneous sequence after deleting its first step" + status: pass + human_judgment: false + - id: D2 + description: "G-06-04-A：多字节 bigint 与超 int32 int64 混合步骤的正确预期已登记，但受 #06-04-1/#06-04-2 阻塞只能 it.skip" + requirement: "TEST-01" + verification: + - kind: unit + ref: "packages-user/data-common/src/replay/array.test.ts#round-trips a heterogeneous step mixing a multi-byte bigint and an int64 value (it.skip)" + status: unknown + human_judgment: true + rationale: "受阻塞缺陷 #06-04-1/#06-04-2 未修复，用例为正确预期 it.skip，跳过不代表通过；需人工确认是否进入修复批次。" + - id: D3 + description: "G-06-03-A：4 朝向复用同一 prefab 生成 4 个独立怪物的正确预期已登记，但受 #06-03-1 阻塞只能 it.skip" + requirement: "TEST-01" + verification: + - kind: unit + ref: "packages-user/data-base/src/enemy/manager.test.ts#creates four independent enemies from one prefab reused by four facing codes (it.skip)" + status: unknown + human_judgment: true + rationale: "受阻塞缺陷 #06-03-1（createEnemy/createEnemyById 未走复用映射）未修复，用例为正确预期 it.skip，跳过不代表通过；需人工确认是否进入修复批次。" + +duration: 13min +completed: 2026-09-15 +status: complete +--- + +# Phase 06 Plan 12: 录像与 enemy 模型覆盖缺口补测 Summary + +**按 D-43 三阶段补齐 G-06-04-B（异质多命令序列读回，可跑绿）、G-06-04-A（多字节 bigint/int64 正确预期 it.skip）、G-06-03-A（四朝向复用同一 prefab 生成独立怪物正确预期 it.skip），仅改测试与覆盖表，无生产代码改动。** + +## Performance + +- **Duration:** 13min +- **Started:** 2026-09-15T02:30:00Z +- **Completed:** 2026-09-15T02:44:00Z +- **Tasks:** 3 +- **Files modified:** 3 + +## Accomplishments + +- **G-06-04-B（可跑绿）**：`array.test.ts` 新增 6 条参数个数与类型各异的录像命令（单 int、boolean + 短 string、空参数、单字节 bigint、多 int、长 string + float），经 `createReadStream` 与 `get` 逐条读回一致，并覆盖加宽到 `Uint16` 后的读回与**删除首步**后的读回。 +- **G-06-04-A（正确预期 skip）**：新增 `it.skip` 覆盖「多字节 bigint + 超 int32 int64 + boolean + string 混在同一步」，锚定既有 `#06-04-1`/`#06-04-2`；既有两条同锚点 skip 保持不变（未取消 skip、未弱化为通过）。 +- **G-06-03-A（正确预期 skip）**：`manager.test.ts` 新增 `it.skip` 覆盖「4 个朝向 code（100..103）/id 复用同一 prefab → `createEnemy`/`createEnemyById` 各生成 4 个互相独立且与模板独立的怪，改一只不影响其余三者与模板」，锚定既有 `#06-03-1`；既有同锚点 skip 不变。 +- `06-COVERAGE-MAP.md` 以 create-or-append 方式追加 06-12 小节（缺口 → 用例 → 文件 → 计划），未重写他节。 + +## Task Commits + +Each task was committed atomically: + +1. **Task 1: 阶段 1（构件级）G-06-04-B 异质录像序列读回** - `0a7f253` (test) +2. **Task 2: 阶段 2（组合）G-06-04-A 正确预期 skip** - `5734025` (test) +3. **Task 3: 阶段 3（完整）G-06-03-A 正确预期 skip + 覆盖表** - `e2c1638` (test) + +**Plan metadata:** _(docs: complete 06-12 plan — 见最终提交)_ + +## Files Created/Modified + +- `packages-user/data-common/src/replay/array.test.ts` - 新增 `heterogeneousSteps` 期望表与文件内 `expectHeterogeneousRead`；新增 3 条可跑绿用例（异质序列读回、uint16 加宽读回、删除首步读回）+ 1 条组合正确预期 `it.skip` +- `packages-user/data-base/src/enemy/manager.test.ts` - reuse mapping 分区新增 1 条四朝向复用生成独立怪物的正确预期 `it.skip` +- `.planning/phases/06-unit-tests/06-COVERAGE-MAP.md` - create-or-append 06-12 小节 + +## Decisions Made + +- **只比较 `command`/`params`**：`createReadStream` 读回的 `index` 为位置 + 1，而 `get(i)` 的 `index === i`，故用 `toMatchObject({ command, params })`，避免整体 `toEqual` 的 ±1 差异（plan 明确要求）。 +- **删除首步可用**：`delete(0)` 是当前可用路径（`#06-04-3` 仅阻塞中间删除），据此覆盖异质序列删除后的读回，未触碰既有 `it.skip`。 +- **复用既有 finding 锚点**：本计划未发现新疑似 bug，不新建 `#06-12-N` 条目；两个受阻塞缺口锚定既有 `#06-04-1`/`#06-04-2`/`#06-03-1`。 + +## Deviations from Plan + +None - plan executed exactly as written. + +## Issues Encountered + +None. 三阶段均先跑绿再进入下一阶段，未出现阻断后续阶段的 bug。 + +## Verification Evidence + +- **阶段 1 聚焦运行**：`pnpm exec vitest run packages-user/data-common/src/replay/array.test.ts` → 1 file passed / 32 passed / 4 skipped。 +- **阶段 2 聚焦运行**：同文件 → 32 passed / 5 skipped（新增 1 条 skip，既有 4 条 skip 锚点不变）。 +- **阶段 3 聚焦运行**：`pnpm exec vitest run packages-user/data-base/src/enemy/manager.test.ts` → 1 file passed / 17 passed / 2 skipped（新增 1 条 skip）。 +- **D-44 门禁（每次提交前）**： + - `pnpm exec eslint --fix <改动文件>` 后 `pnpm exec eslint <改动文件>` → exit 0（3 次均 0 错误）。 + - `pnpm exec vue-tsc --noEmit` 输出按改动测试文件路径过滤 → 0 匹配（`replay/array.test.ts`、`enemy/manager.test.ts`）；全局既有无关错误 27 条不在本门禁范围。 + - `pnpm test:ci` → 全绿：执行前 66 文件 / 641 通过 / 20 跳过；阶段 1 后 644 通过 / 20 跳过；阶段 2 后 644 通过 / 21 跳过；阶段 3 后 **644 通过 / 22 跳过**（新增 3 通过 + 2 skip，无失败）。 +- **变更范围**：`git status` 仅显示两个 `*.test.ts` 与 `06-COVERAGE-MAP.md`；无生产/核心源码改动。 + +## Known Stubs + +None - 无桩代码；两条 `it.skip` 为受阻塞缺口的正确预期登记（D-05/D-46），已登记于 `06-TEST-FINDINGS.md` 既有条目 `#06-04-1`/`#06-04-2`/`#06-03-1`。 + +## Next Phase Readiness + +- 06-04（录像）与 06-03（enemy 数据模型）人工评审发现的覆盖缺口（G-06-04-A/B、G-06-03-A）已全部收口。 +- 后续若修复 `#06-04-1`/`#06-04-2`/`#06-03-1`，需取消对应 `it.skip` 并转为可跑绿回归用例（D-05）。 + +## Self-Check: PASSED + +- FOUND: .planning/phases/06-unit-tests/06-12-SUMMARY.md +- FOUND: 0a7f253 (Task 1) +- FOUND: 5734025 (Task 2) +- FOUND: e2c1638 (Task 3) + +--- +*Phase: 06-unit-tests* +*Completed: 2026-09-15* diff --git a/.planning/phases/06-unit-tests/06-TEST-FINDINGS.md b/.planning/phases/06-unit-tests/06-TEST-FINDINGS.md index 34b19c9..ed658b8 100644 --- a/.planning/phases/06-unit-tests/06-TEST-FINDINGS.md +++ b/.planning/phases/06-unit-tests/06-TEST-FINDINGS.md @@ -186,3 +186,24 @@ D-45：公开 `CoreState.saveState(compression)` / `loadState(state, compression 非缺陷说明：阶段 1 计划措辞「type 取最大」与顶层 `MainMapDamageReducer`「取最大伤害项的 type」语义不同；本计划按 plan 措辞以文件内联语义 reducer 断言，未改动生产代码。 + +## #06-12 录像与 enemy 模型缺口补测（D-46） + +本计划按 D-43 三阶段（构件 → 组合 → 完整）补齐 G-06-04-B、G-06-04-A、G-06-03-A， +只新增/扩展 `*.test.ts`，未改动任何生产/核心源码；两个测试文件聚焦运行通过， +`pnpm test:ci` 全绿（66 文件 / **644 通过** / **21 跳过**）。 + +- 阶段 1 构件级（`replay/array.test.ts`）：G-06-04-B 可跑绿——6 条参数个数与类型各异的命令 + （单 int、boolean + 短 string、空参数、单字节 bigint、多 int、长 string + float）经 + `createReadStream` 与 `get` 逐条读回一致（读流 `index = position + 1`、`get` 的 `index = i`， + 故只比较 `command`/`params`），并覆盖加宽到 uint16 后的读回与**删除首步**后的读回。 +- 阶段 2 组合（`replay/array.test.ts`）：G-06-04-A——新增一条正确预期 `it.skip` + `round-trips a heterogeneous step mixing a multi-byte bigint and an int64 value`， + 锚定既有 `#06-04-1`/`#06-04-2`；既有两条同锚点 skip 保持不变，未取消 skip。 +- 阶段 3 完整（`enemy/manager.test.ts`）：G-06-03-A——新增一条正确预期 `it.skip` + `creates four independent enemies from one prefab reused by four facing codes`， + 覆盖「4 个朝向 code/id 复用同一 prefab → 分别 `createEnemy`/`createEnemyById` 得到 4 个 + 互相独立且与模板独立的怪」的完整链路，锚定既有 `#06-03-1`；既有同锚点 skip 不变。 + +**本计划未发现新疑似 bug**，无新增 `#06-12-N` 条目；受阻塞缺口复用既有 +`#06-04-1`/`#06-04-2`/`#06-03-1` 锚点（详见上文 `## #06-04` 与 `## #06-03` 小节）。 diff --git a/.planning/state.json b/.planning/state.json index 83501d4..3548d04 100644 --- a/.planning/state.json +++ b/.planning/state.json @@ -39,5 +39,5 @@ "label": "Advance to the next step", "reason": "Phase 06 of 6 · executing" }, - "updated_at": "2026-09-15T02:29:42.579Z" + "updated_at": "2026-09-15T02:44:51.310Z" }